stable_pool: math #414
Open
stable_pool: math #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueco-jb
reviewed
Jan 9, 2025
ueco-jb
reviewed
Jan 15, 2025
gangov
force-pushed
the
kalo/stable_pool-math
branch
from
1004f11 to
7833db9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scale_value: now uses theenvparameter andU256type for handling larger numbers, preventing overflow issues.compute_d: refactored to use theU256type for precise multiplication and division.compute_d: should be achieving the same approximation of D using an optimized approach.calc_y: uses a reordered formula and iterative (Newton-like) methods for the swap amount calculations.calc_y: the complex arithmetic operations are broken into smaller, manageable steps to prevent overflow errors and products of numbers that don't fit inU256(eg.200000000000000000000000^3 x 100000000000).